fix: separate Compactions and ContextBombsDelivered counters in buildReportData#435
Merged
claude[bot] merged 1 commit intomainfrom Mar 1, 2026
Merged
Conversation
…ReportData Compactions now counts only EventRun entries where SessionSnapshotPresent is true (genuine compaction events where the PreCompact hook ran). ContextBombsDelivered counts all EventRun entries regardless of snapshot presence. Also adds backward-compatibility handling for entries with an empty EventType field, treating them as EventRun (same logic already present in ReadAll). Fixes #432 Co-Authored-By: Grey Newell <greyshipscode@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
cmd/report.go - buildReportData:
Test
The existing TestBuildReportData_CompactionCount test at cmd/report_test.go:178 documents and verifies this exact distinction. With this fix, that test passes along with the other buildReportData tests that use entries without EventType set (now handled by the backward-compat path).
Fixes #432
Generated with Claude Code